Detecting if an element is found inside a containercontains() algorithm for std::vectorSimple container class with templatesPolymorphic STL foreach without passing the container typeGeneric container assignmentC++11 Quicksort any containerTriple-type template containerCreating a custom template container class (vector alike)Shift an element in a circular containerNon-sequential template class container C++Internal Zip-like IteratorBasic binary number container

How does it work when somebody invests in my business?

Purchasing a ticket for someone else in another country?

Proof of work - lottery approach

Opposite of a diet

Do sorcerers' Subtle Spells require a skill check to be unseen?

Was Spock the First Vulcan in Starfleet?

How to safely derail a train during transit?

Crossing the line between justified force and brutality

Why Were Madagascar and New Zealand Discovered So Late?

Closest Prime Number

How do I find the solutions of the following equation?

when is out of tune ok?

Increase performance creating Mandelbrot set in python

Large drywall patch supports

Do all network devices need to make routing decisions, regardless of communication across networks or within a network?

Implement the Thanos sorting algorithm

What does "I’d sit this one out, Cap," imply or mean in the context?

How to run a prison with the smallest amount of guards?

What is the best translation for "slot" in the context of multiplayer video games?

Failed to fetch jessie backports repository

How does buying out courses with grant money work?

What can we do to stop prior company from asking us questions?

What is the opposite of 'gravitas'?

Are student evaluations of teaching assistants read by others in the faculty?



Detecting if an element is found inside a container


contains() algorithm for std::vectorSimple container class with templatesPolymorphic STL foreach without passing the container typeGeneric container assignmentC++11 Quicksort any containerTriple-type template containerCreating a custom template container class (vector alike)Shift an element in a circular containerNon-sequential template class container C++Internal Zip-like IteratorBasic binary number container













3












$begingroup$


I just wrote this template to detect if a given element is found inside a container:



template <typename Iterator> bool is_contained(Iterator begin, Iterator end, decltype(*begin) object)

for (; begin != end; ++begin)

if (*begin == object)

return true;


return false;



Which then would be called for examples as:



bool test = is_contained<decltype(container.begin())>(container.begin(), container.end(), anything);


This works fine, but I believe it is not so readable. I am also new to using decltype which makes me wonder if this would crash, and somehow I wont be calling the template correctly. Any feedback is highly appreciated.










share|improve this question







New contributor




Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$
















    3












    $begingroup$


    I just wrote this template to detect if a given element is found inside a container:



    template <typename Iterator> bool is_contained(Iterator begin, Iterator end, decltype(*begin) object)

    for (; begin != end; ++begin)

    if (*begin == object)

    return true;


    return false;



    Which then would be called for examples as:



    bool test = is_contained<decltype(container.begin())>(container.begin(), container.end(), anything);


    This works fine, but I believe it is not so readable. I am also new to using decltype which makes me wonder if this would crash, and somehow I wont be calling the template correctly. Any feedback is highly appreciated.










    share|improve this question







    New contributor




    Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$














      3












      3








      3





      $begingroup$


      I just wrote this template to detect if a given element is found inside a container:



      template <typename Iterator> bool is_contained(Iterator begin, Iterator end, decltype(*begin) object)

      for (; begin != end; ++begin)

      if (*begin == object)

      return true;


      return false;



      Which then would be called for examples as:



      bool test = is_contained<decltype(container.begin())>(container.begin(), container.end(), anything);


      This works fine, but I believe it is not so readable. I am also new to using decltype which makes me wonder if this would crash, and somehow I wont be calling the template correctly. Any feedback is highly appreciated.










      share|improve this question







      New contributor




      Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I just wrote this template to detect if a given element is found inside a container:



      template <typename Iterator> bool is_contained(Iterator begin, Iterator end, decltype(*begin) object)

      for (; begin != end; ++begin)

      if (*begin == object)

      return true;


      return false;



      Which then would be called for examples as:



      bool test = is_contained<decltype(container.begin())>(container.begin(), container.end(), anything);


      This works fine, but I believe it is not so readable. I am also new to using decltype which makes me wonder if this would crash, and somehow I wont be calling the template correctly. Any feedback is highly appreciated.







      c++ beginner template






      share|improve this question







      New contributor




      Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question







      New contributor




      Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question






      New contributor




      Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 6 hours ago









      Daniel DuqueDaniel Duque

      485




      485




      New contributor




      Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.




















          2 Answers
          2






          active

          oldest

          votes


















          5












          $begingroup$

          Note that for functions the compiler will detect the template types based on the parameters.

          So you can simply write:



          bool test = is_contained(container.begin(), container.end(), anything);


          I don't particularly like the use of decltype in your function. I would simply make it another template parameter.



          template <typename Iterator, typename Value>
          bool is_contained(Iterator begin, Iterator end, Value const& object);


          Because of the compiler deducing the names you can use any type. Also this is more flexable as it allows you to use any type that is comparable to the type inside the container (rather than only allowing values that are the same type (or trivial convertible)).






          share|improve this answer









          $endgroup$




















            3












            $begingroup$


            1. Do you want to test whether an element is in a container, or an iterator-range?



              • The first allows for optimisation (taking advantage of the container's peculiarities). See "contains() algorithm for std::vector" for an example.

              • The second is more general in the absence of any range-library, like the one expected for the C++20 standard, and available for earlier versions.



            2. Constraining the needle to the type decltype(*begin) is very problematic:



              • It forces pass-by-value, which while it should be possible, at least with moveing, might be inefficient.

              • You cannot take advantage of transparent comparators (a C++14 feature), forcing the creation of a useless temporary. On the flip-side, if transparent comparators are not used, only a single temporary is constructed.

              • If the type is a proxy like with the dreaded std::vector <bool>, hilarity ensues.


            3. Consider taking advantage of the standard library, specifically std::find ().


            4. C++ will deduce the function's template-arguments perfectly fine, no need for error-prone verbosity.






            share|improve this answer









            $endgroup$












              Your Answer





              StackExchange.ifUsing("editor", function ()
              return StackExchange.using("mathjaxEditing", function ()
              StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
              StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
              );
              );
              , "mathjax-editing");

              StackExchange.ifUsing("editor", function ()
              StackExchange.using("externalEditor", function ()
              StackExchange.using("snippets", function ()
              StackExchange.snippets.init();
              );
              );
              , "code-snippets");

              StackExchange.ready(function()
              var channelOptions =
              tags: "".split(" "),
              id: "196"
              ;
              initTagRenderer("".split(" "), "".split(" "), channelOptions);

              StackExchange.using("externalEditor", function()
              // Have to fire editor after snippets, if snippets enabled
              if (StackExchange.settings.snippets.snippetsEnabled)
              StackExchange.using("snippets", function()
              createEditor();
              );

              else
              createEditor();

              );

              function createEditor()
              StackExchange.prepareEditor(
              heartbeatType: 'answer',
              autoActivateHeartbeat: false,
              convertImagesToLinks: false,
              noModals: true,
              showLowRepImageUploadWarning: true,
              reputationToPostImages: null,
              bindNavPrevention: true,
              postfix: "",
              imageUploader:
              brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
              contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
              allowUrls: true
              ,
              onDemand: true,
              discardSelector: ".discard-answer"
              ,immediatelyShowMarkdownHelp:true
              );



              );






              Daniel Duque is a new contributor. Be nice, and check out our Code of Conduct.









              draft saved

              draft discarded


















              StackExchange.ready(
              function ()
              StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216361%2fdetecting-if-an-element-is-found-inside-a-container%23new-answer', 'question_page');

              );

              Post as a guest















              Required, but never shown

























              2 Answers
              2






              active

              oldest

              votes








              2 Answers
              2






              active

              oldest

              votes









              active

              oldest

              votes






              active

              oldest

              votes









              5












              $begingroup$

              Note that for functions the compiler will detect the template types based on the parameters.

              So you can simply write:



              bool test = is_contained(container.begin(), container.end(), anything);


              I don't particularly like the use of decltype in your function. I would simply make it another template parameter.



              template <typename Iterator, typename Value>
              bool is_contained(Iterator begin, Iterator end, Value const& object);


              Because of the compiler deducing the names you can use any type. Also this is more flexable as it allows you to use any type that is comparable to the type inside the container (rather than only allowing values that are the same type (or trivial convertible)).






              share|improve this answer









              $endgroup$

















                5












                $begingroup$

                Note that for functions the compiler will detect the template types based on the parameters.

                So you can simply write:



                bool test = is_contained(container.begin(), container.end(), anything);


                I don't particularly like the use of decltype in your function. I would simply make it another template parameter.



                template <typename Iterator, typename Value>
                bool is_contained(Iterator begin, Iterator end, Value const& object);


                Because of the compiler deducing the names you can use any type. Also this is more flexable as it allows you to use any type that is comparable to the type inside the container (rather than only allowing values that are the same type (or trivial convertible)).






                share|improve this answer









                $endgroup$















                  5












                  5








                  5





                  $begingroup$

                  Note that for functions the compiler will detect the template types based on the parameters.

                  So you can simply write:



                  bool test = is_contained(container.begin(), container.end(), anything);


                  I don't particularly like the use of decltype in your function. I would simply make it another template parameter.



                  template <typename Iterator, typename Value>
                  bool is_contained(Iterator begin, Iterator end, Value const& object);


                  Because of the compiler deducing the names you can use any type. Also this is more flexable as it allows you to use any type that is comparable to the type inside the container (rather than only allowing values that are the same type (or trivial convertible)).






                  share|improve this answer









                  $endgroup$



                  Note that for functions the compiler will detect the template types based on the parameters.

                  So you can simply write:



                  bool test = is_contained(container.begin(), container.end(), anything);


                  I don't particularly like the use of decltype in your function. I would simply make it another template parameter.



                  template <typename Iterator, typename Value>
                  bool is_contained(Iterator begin, Iterator end, Value const& object);


                  Because of the compiler deducing the names you can use any type. Also this is more flexable as it allows you to use any type that is comparable to the type inside the container (rather than only allowing values that are the same type (or trivial convertible)).







                  share|improve this answer












                  share|improve this answer



                  share|improve this answer










                  answered 6 hours ago









                  Martin YorkMartin York

                  74k488271




                  74k488271























                      3












                      $begingroup$


                      1. Do you want to test whether an element is in a container, or an iterator-range?



                        • The first allows for optimisation (taking advantage of the container's peculiarities). See "contains() algorithm for std::vector" for an example.

                        • The second is more general in the absence of any range-library, like the one expected for the C++20 standard, and available for earlier versions.



                      2. Constraining the needle to the type decltype(*begin) is very problematic:



                        • It forces pass-by-value, which while it should be possible, at least with moveing, might be inefficient.

                        • You cannot take advantage of transparent comparators (a C++14 feature), forcing the creation of a useless temporary. On the flip-side, if transparent comparators are not used, only a single temporary is constructed.

                        • If the type is a proxy like with the dreaded std::vector <bool>, hilarity ensues.


                      3. Consider taking advantage of the standard library, specifically std::find ().


                      4. C++ will deduce the function's template-arguments perfectly fine, no need for error-prone verbosity.






                      share|improve this answer









                      $endgroup$

















                        3












                        $begingroup$


                        1. Do you want to test whether an element is in a container, or an iterator-range?



                          • The first allows for optimisation (taking advantage of the container's peculiarities). See "contains() algorithm for std::vector" for an example.

                          • The second is more general in the absence of any range-library, like the one expected for the C++20 standard, and available for earlier versions.



                        2. Constraining the needle to the type decltype(*begin) is very problematic:



                          • It forces pass-by-value, which while it should be possible, at least with moveing, might be inefficient.

                          • You cannot take advantage of transparent comparators (a C++14 feature), forcing the creation of a useless temporary. On the flip-side, if transparent comparators are not used, only a single temporary is constructed.

                          • If the type is a proxy like with the dreaded std::vector <bool>, hilarity ensues.


                        3. Consider taking advantage of the standard library, specifically std::find ().


                        4. C++ will deduce the function's template-arguments perfectly fine, no need for error-prone verbosity.






                        share|improve this answer









                        $endgroup$















                          3












                          3








                          3





                          $begingroup$


                          1. Do you want to test whether an element is in a container, or an iterator-range?



                            • The first allows for optimisation (taking advantage of the container's peculiarities). See "contains() algorithm for std::vector" for an example.

                            • The second is more general in the absence of any range-library, like the one expected for the C++20 standard, and available for earlier versions.



                          2. Constraining the needle to the type decltype(*begin) is very problematic:



                            • It forces pass-by-value, which while it should be possible, at least with moveing, might be inefficient.

                            • You cannot take advantage of transparent comparators (a C++14 feature), forcing the creation of a useless temporary. On the flip-side, if transparent comparators are not used, only a single temporary is constructed.

                            • If the type is a proxy like with the dreaded std::vector <bool>, hilarity ensues.


                          3. Consider taking advantage of the standard library, specifically std::find ().


                          4. C++ will deduce the function's template-arguments perfectly fine, no need for error-prone verbosity.






                          share|improve this answer









                          $endgroup$




                          1. Do you want to test whether an element is in a container, or an iterator-range?



                            • The first allows for optimisation (taking advantage of the container's peculiarities). See "contains() algorithm for std::vector" for an example.

                            • The second is more general in the absence of any range-library, like the one expected for the C++20 standard, and available for earlier versions.



                          2. Constraining the needle to the type decltype(*begin) is very problematic:



                            • It forces pass-by-value, which while it should be possible, at least with moveing, might be inefficient.

                            • You cannot take advantage of transparent comparators (a C++14 feature), forcing the creation of a useless temporary. On the flip-side, if transparent comparators are not used, only a single temporary is constructed.

                            • If the type is a proxy like with the dreaded std::vector <bool>, hilarity ensues.


                          3. Consider taking advantage of the standard library, specifically std::find ().


                          4. C++ will deduce the function's template-arguments perfectly fine, no need for error-prone verbosity.







                          share|improve this answer












                          share|improve this answer



                          share|improve this answer










                          answered 5 hours ago









                          DeduplicatorDeduplicator

                          11.7k1950




                          11.7k1950




















                              Daniel Duque is a new contributor. Be nice, and check out our Code of Conduct.









                              draft saved

                              draft discarded


















                              Daniel Duque is a new contributor. Be nice, and check out our Code of Conduct.












                              Daniel Duque is a new contributor. Be nice, and check out our Code of Conduct.











                              Daniel Duque is a new contributor. Be nice, and check out our Code of Conduct.














                              Thanks for contributing an answer to Code Review Stack Exchange!


                              • Please be sure to answer the question. Provide details and share your research!

                              But avoid


                              • Asking for help, clarification, or responding to other answers.

                              • Making statements based on opinion; back them up with references or personal experience.

                              Use MathJax to format equations. MathJax reference.


                              To learn more, see our tips on writing great answers.




                              draft saved


                              draft discarded














                              StackExchange.ready(
                              function ()
                              StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216361%2fdetecting-if-an-element-is-found-inside-a-container%23new-answer', 'question_page');

                              );

                              Post as a guest















                              Required, but never shown





















































                              Required, but never shown














                              Required, but never shown












                              Required, but never shown







                              Required, but never shown

































                              Required, but never shown














                              Required, but never shown












                              Required, but never shown







                              Required, but never shown







                              Popular posts from this blog

                              How to create a command for the “strange m” symbol in latex? Announcing the arrival of Valued Associate #679: Cesar Manara Planned maintenance scheduled April 23, 2019 at 23:30 UTC (7:30pm US/Eastern)How do you make your own symbol when Detexify fails?Writing bold small caps with mathpazo packageplus-minus symbol with parenthesis around the minus signGreek character in Beamer document titleHow to create dashed right arrow over symbol?Currency symbol: Turkish LiraDouble prec as a single symbol?Plus Sign Too Big; How to Call adfbullet?Is there a TeX macro for three-legged pi?How do I get my integral-like symbol to align like the integral?How to selectively substitute a letter with another symbol representing the same letterHow do I generate a less than symbol and vertical bar that are the same height?

                              Българска екзархия Съдържание История | Български екзарси | Вижте също | Външни препратки | Литература | Бележки | НавигацияУстав за управлението на българската екзархия. Цариград, 1870Слово на Ловешкия митрополит Иларион при откриването на Българския народен събор в Цариград на 23. II. 1870 г.Българската правда и гръцката кривда. От С. М. (= Софийски Мелетий). Цариград, 1872Предстоятели на Българската екзархияПодмененият ВеликденИнформационна агенция „Фокус“Димитър Ризов. Българите в техните исторически, етнографически и политически граници (Атлас съдържащ 40 карти). Berlin, Königliche Hoflithographie, Hof-Buch- und -Steindruckerei Wilhelm Greve, 1917Report of the International Commission to Inquire into the Causes and Conduct of the Balkan Wars

                              Чепеларе Съдържание География | История | Население | Спортни и природни забележителности | Културни и исторически обекти | Религии | Обществени институции | Известни личности | Редовни събития | Галерия | Източници | Литература | Външни препратки | Навигация41°43′23.99″ с. ш. 24°41′09.99″ и. д. / 41.723333° с. ш. 24.686111° и. д.*ЧепелареЧепеларски Linux fest 2002Начало на Зимен сезон 2005/06Национални хайдушки празници „Капитан Петко Войвода“Град ЧепелареЧепеларе – народният ски курортbgrod.orgwww.terranatura.hit.bgСправка за населението на гр. Исперих, общ. Исперих, обл. РазградМузей на родопския карстМузей на спорта и скитеЧепеларебългарскибългарскианглийскитукИстория на градаСки писти в ЧепелареВремето в ЧепелареРадио и телевизия в ЧепелареЧепеларе мами с родопски чар и добри пистиЕвтин туризъм и снежни атракции в ЧепелареМестоположениеИнформация и снимки от музея на родопския карст3D панорами от ЧепелареЧепелареррр