Calculator final project in Python The Next CEO of Stack OverflowPython calculator scriptSimple calculator for an interviewSimple python calculatorPython calculatorPython 3 - CalculatorPython BMI CalculatorSemi-simple calculatortkinter calculator college projectBasic calculator in PythonSimple Python calculator 5
How to prove a simple equation?
Would a completely good Muggle be able to use a wand?
Why did CATV standarize in 75 ohms and everyone else in 50?
Why isn't the Mueller report being released completely and unredacted?
Can MTA send mail via a relay without being told so?
Which one is the true statement?
Where do students learn to solve polynomial equations these days?
RigExpert AA-35 - Interpreting The Information
Does Germany produce more waste than the US?
Should I tutor a student who I know has cheated on their homework?
Is French Guiana a (hard) EU border?
What steps are necessary to read a Modern SSD in Medieval Europe?
Why do airplanes bank sharply to the right after air-to-air refueling?
Why doesn't UK go for the same deal Japan has with EU to resolve Brexit?
Proper way to express "He disappeared them"
Why is the US ranked as #45 in Press Freedom ratings, despite its extremely permissive free speech laws?
What connection does MS Office have to Netscape Navigator?
Legal workarounds for testamentary trust perceived as unfair
How to invert MapIndexed on a ragged structure? How to construct a tree from rules?
How to get from Geneva Airport to Metabief, Doubs, France by public transport?
Math-accent symbol over parentheses enclosing accented symbol (amsmath)
Is it possible to use a NPN BJT as switch, from single power source?
Necessary condition on homology group for a set to be contractible
Is wanting to ask what to write an indication that you need to change your story?
Calculator final project in Python
The Next CEO of Stack OverflowPython calculator scriptSimple calculator for an interviewSimple python calculatorPython calculatorPython 3 - CalculatorPython BMI CalculatorSemi-simple calculatortkinter calculator college projectBasic calculator in PythonSimple Python calculator 5
$begingroup$
In my final project for my Python course, I am required to create a calculator program. I really need someone to look over my code and tell me if I have met all the requirements for this project.
Here are the requirements:
For the final project, you are to write a calculator program in Python
with the following characteristics:
- It must be at least 50 lines of code excluding comments
- It must have the following functions:+,-,*,/, SQRT, and work with decimal numbers.
- It must be all text, no high resolution graphics
- It must automatically copy the result to the operating system clipboard
- It must work as a functional calculator (calculations can be entered over and over)
Please submit the source code only (.py), no object code (I will
compile on receipt)
NOTE:
This assignment is graded on a pass/fail basis; there is no partial credit or resubmissions. Be sure you understand ALL of the
requirements.
Solutions that require the user install any software will NOT be accepted (in case you are not sure, this means NO Pyperclip.)
WARNING: All submissions will be checked for plagiarism using
SafeAssign or other plagiarism checker.
I completed the project, but because this is a pass/fail project I want to be 200% sure I have met every requirement. I am also open to any other feedback that would sharpen my Python skills.
Menu
def main():
#Menu
print("=======================")
print("Welcome to Calculator")
print("By: Tyler Harris")
print("=======================")
print("Menu: ")
print("[1] Calculator")
print("[2] Instructions")
print("[3] Exit")
print("=======================")
choice = input("Please select an option: ")
if choice == '1':
calculator()
elif choice == '2':
instructions()
main()
elif choice == '3':
print("Thank you for using Calculator.")
else:
print("Not an option, try again:")
main()
Calculator
def calculator():
result=0 #Resets calulator.
try:
while True:
print("Last Result: "+str(result))
#Number 1 input.
if result == 0:
num1= int(input("First Number: "))
if result != 0:
num1=result
#Operator input.
#Checks for input of special operators 'c', 'sqrt', and 'esc'.
operator=input("Opertaor: ").lower()
if operator == "c":
print("Calculator cleared")
calculator()
if operator=="sqrt":
result=(sqrt(num1))
print("Result: "+str(result))
continue
if operator=="esc":
main()
if operator.isdigit(): #Throw error if operator is a number.
raise Exception()
#Number 2 input.
num2= int(input("Second Number: "))
#Operator calls.
if operator=="+":
result=(add(num1,num2))
elif operator=="-":
result=(sub(num1,num2))
elif operator=="*":
result=(mult(num1,num2))
elif operator=="/":
result=(div(num1,num2))
#Copy result to System's clipboard and display the result.
copy2clip(str(result))
print("=======================")
print("Result: "+str(result))
print("copied to clipboard")
print("=======================")
#Catch any errors and reset calculator
except Exception:
print("=======================")
print("Error Please try again.")
calculator()
else:
calculator()
Operators
def add(num1,num2):
return num1 + num2
def sub(num1,num2):
return num1 - num2
def mult(num1,num2):
return num1 * num2
def div(num1,num2):
return num1 / num2
def sqrt(num1):
return (num1**(1/2.0))
Instructions
def instructions():
print("=======================")
print(format('Calculator','^25s'))
print("=======================")
print("Available operators")
print("+: Addition")
print("-: Subtraction")
print("*: Multiplication")
print("/: Division")
print("sqrt: Square Root")
print("c: Clear Calculator")
print("esc: Exit Calculator")
print("=======================")
def copy2clip(txt):
cmd='echo '+txt.strip()+'|clip'
return subprocess.check_call(cmd, shell=True)
if __name__=='__main__':
main()
python python-3.x homework calculator
$endgroup$
migrated from stackoverflow.com 3 hours ago
This question came from our site for professional and enthusiast programmers.
add a comment |
$begingroup$
In my final project for my Python course, I am required to create a calculator program. I really need someone to look over my code and tell me if I have met all the requirements for this project.
Here are the requirements:
For the final project, you are to write a calculator program in Python
with the following characteristics:
- It must be at least 50 lines of code excluding comments
- It must have the following functions:+,-,*,/, SQRT, and work with decimal numbers.
- It must be all text, no high resolution graphics
- It must automatically copy the result to the operating system clipboard
- It must work as a functional calculator (calculations can be entered over and over)
Please submit the source code only (.py), no object code (I will
compile on receipt)
NOTE:
This assignment is graded on a pass/fail basis; there is no partial credit or resubmissions. Be sure you understand ALL of the
requirements.
Solutions that require the user install any software will NOT be accepted (in case you are not sure, this means NO Pyperclip.)
WARNING: All submissions will be checked for plagiarism using
SafeAssign or other plagiarism checker.
I completed the project, but because this is a pass/fail project I want to be 200% sure I have met every requirement. I am also open to any other feedback that would sharpen my Python skills.
Menu
def main():
#Menu
print("=======================")
print("Welcome to Calculator")
print("By: Tyler Harris")
print("=======================")
print("Menu: ")
print("[1] Calculator")
print("[2] Instructions")
print("[3] Exit")
print("=======================")
choice = input("Please select an option: ")
if choice == '1':
calculator()
elif choice == '2':
instructions()
main()
elif choice == '3':
print("Thank you for using Calculator.")
else:
print("Not an option, try again:")
main()
Calculator
def calculator():
result=0 #Resets calulator.
try:
while True:
print("Last Result: "+str(result))
#Number 1 input.
if result == 0:
num1= int(input("First Number: "))
if result != 0:
num1=result
#Operator input.
#Checks for input of special operators 'c', 'sqrt', and 'esc'.
operator=input("Opertaor: ").lower()
if operator == "c":
print("Calculator cleared")
calculator()
if operator=="sqrt":
result=(sqrt(num1))
print("Result: "+str(result))
continue
if operator=="esc":
main()
if operator.isdigit(): #Throw error if operator is a number.
raise Exception()
#Number 2 input.
num2= int(input("Second Number: "))
#Operator calls.
if operator=="+":
result=(add(num1,num2))
elif operator=="-":
result=(sub(num1,num2))
elif operator=="*":
result=(mult(num1,num2))
elif operator=="/":
result=(div(num1,num2))
#Copy result to System's clipboard and display the result.
copy2clip(str(result))
print("=======================")
print("Result: "+str(result))
print("copied to clipboard")
print("=======================")
#Catch any errors and reset calculator
except Exception:
print("=======================")
print("Error Please try again.")
calculator()
else:
calculator()
Operators
def add(num1,num2):
return num1 + num2
def sub(num1,num2):
return num1 - num2
def mult(num1,num2):
return num1 * num2
def div(num1,num2):
return num1 / num2
def sqrt(num1):
return (num1**(1/2.0))
Instructions
def instructions():
print("=======================")
print(format('Calculator','^25s'))
print("=======================")
print("Available operators")
print("+: Addition")
print("-: Subtraction")
print("*: Multiplication")
print("/: Division")
print("sqrt: Square Root")
print("c: Clear Calculator")
print("esc: Exit Calculator")
print("=======================")
def copy2clip(txt):
cmd='echo '+txt.strip()+'|clip'
return subprocess.check_call(cmd, shell=True)
if __name__=='__main__':
main()
python python-3.x homework calculator
$endgroup$
migrated from stackoverflow.com 3 hours ago
This question came from our site for professional and enthusiast programmers.
add a comment |
$begingroup$
In my final project for my Python course, I am required to create a calculator program. I really need someone to look over my code and tell me if I have met all the requirements for this project.
Here are the requirements:
For the final project, you are to write a calculator program in Python
with the following characteristics:
- It must be at least 50 lines of code excluding comments
- It must have the following functions:+,-,*,/, SQRT, and work with decimal numbers.
- It must be all text, no high resolution graphics
- It must automatically copy the result to the operating system clipboard
- It must work as a functional calculator (calculations can be entered over and over)
Please submit the source code only (.py), no object code (I will
compile on receipt)
NOTE:
This assignment is graded on a pass/fail basis; there is no partial credit or resubmissions. Be sure you understand ALL of the
requirements.
Solutions that require the user install any software will NOT be accepted (in case you are not sure, this means NO Pyperclip.)
WARNING: All submissions will be checked for plagiarism using
SafeAssign or other plagiarism checker.
I completed the project, but because this is a pass/fail project I want to be 200% sure I have met every requirement. I am also open to any other feedback that would sharpen my Python skills.
Menu
def main():
#Menu
print("=======================")
print("Welcome to Calculator")
print("By: Tyler Harris")
print("=======================")
print("Menu: ")
print("[1] Calculator")
print("[2] Instructions")
print("[3] Exit")
print("=======================")
choice = input("Please select an option: ")
if choice == '1':
calculator()
elif choice == '2':
instructions()
main()
elif choice == '3':
print("Thank you for using Calculator.")
else:
print("Not an option, try again:")
main()
Calculator
def calculator():
result=0 #Resets calulator.
try:
while True:
print("Last Result: "+str(result))
#Number 1 input.
if result == 0:
num1= int(input("First Number: "))
if result != 0:
num1=result
#Operator input.
#Checks for input of special operators 'c', 'sqrt', and 'esc'.
operator=input("Opertaor: ").lower()
if operator == "c":
print("Calculator cleared")
calculator()
if operator=="sqrt":
result=(sqrt(num1))
print("Result: "+str(result))
continue
if operator=="esc":
main()
if operator.isdigit(): #Throw error if operator is a number.
raise Exception()
#Number 2 input.
num2= int(input("Second Number: "))
#Operator calls.
if operator=="+":
result=(add(num1,num2))
elif operator=="-":
result=(sub(num1,num2))
elif operator=="*":
result=(mult(num1,num2))
elif operator=="/":
result=(div(num1,num2))
#Copy result to System's clipboard and display the result.
copy2clip(str(result))
print("=======================")
print("Result: "+str(result))
print("copied to clipboard")
print("=======================")
#Catch any errors and reset calculator
except Exception:
print("=======================")
print("Error Please try again.")
calculator()
else:
calculator()
Operators
def add(num1,num2):
return num1 + num2
def sub(num1,num2):
return num1 - num2
def mult(num1,num2):
return num1 * num2
def div(num1,num2):
return num1 / num2
def sqrt(num1):
return (num1**(1/2.0))
Instructions
def instructions():
print("=======================")
print(format('Calculator','^25s'))
print("=======================")
print("Available operators")
print("+: Addition")
print("-: Subtraction")
print("*: Multiplication")
print("/: Division")
print("sqrt: Square Root")
print("c: Clear Calculator")
print("esc: Exit Calculator")
print("=======================")
def copy2clip(txt):
cmd='echo '+txt.strip()+'|clip'
return subprocess.check_call(cmd, shell=True)
if __name__=='__main__':
main()
python python-3.x homework calculator
$endgroup$
In my final project for my Python course, I am required to create a calculator program. I really need someone to look over my code and tell me if I have met all the requirements for this project.
Here are the requirements:
For the final project, you are to write a calculator program in Python
with the following characteristics:
- It must be at least 50 lines of code excluding comments
- It must have the following functions:+,-,*,/, SQRT, and work with decimal numbers.
- It must be all text, no high resolution graphics
- It must automatically copy the result to the operating system clipboard
- It must work as a functional calculator (calculations can be entered over and over)
Please submit the source code only (.py), no object code (I will
compile on receipt)
NOTE:
This assignment is graded on a pass/fail basis; there is no partial credit or resubmissions. Be sure you understand ALL of the
requirements.
Solutions that require the user install any software will NOT be accepted (in case you are not sure, this means NO Pyperclip.)
WARNING: All submissions will be checked for plagiarism using
SafeAssign or other plagiarism checker.
I completed the project, but because this is a pass/fail project I want to be 200% sure I have met every requirement. I am also open to any other feedback that would sharpen my Python skills.
Menu
def main():
#Menu
print("=======================")
print("Welcome to Calculator")
print("By: Tyler Harris")
print("=======================")
print("Menu: ")
print("[1] Calculator")
print("[2] Instructions")
print("[3] Exit")
print("=======================")
choice = input("Please select an option: ")
if choice == '1':
calculator()
elif choice == '2':
instructions()
main()
elif choice == '3':
print("Thank you for using Calculator.")
else:
print("Not an option, try again:")
main()
Calculator
def calculator():
result=0 #Resets calulator.
try:
while True:
print("Last Result: "+str(result))
#Number 1 input.
if result == 0:
num1= int(input("First Number: "))
if result != 0:
num1=result
#Operator input.
#Checks for input of special operators 'c', 'sqrt', and 'esc'.
operator=input("Opertaor: ").lower()
if operator == "c":
print("Calculator cleared")
calculator()
if operator=="sqrt":
result=(sqrt(num1))
print("Result: "+str(result))
continue
if operator=="esc":
main()
if operator.isdigit(): #Throw error if operator is a number.
raise Exception()
#Number 2 input.
num2= int(input("Second Number: "))
#Operator calls.
if operator=="+":
result=(add(num1,num2))
elif operator=="-":
result=(sub(num1,num2))
elif operator=="*":
result=(mult(num1,num2))
elif operator=="/":
result=(div(num1,num2))
#Copy result to System's clipboard and display the result.
copy2clip(str(result))
print("=======================")
print("Result: "+str(result))
print("copied to clipboard")
print("=======================")
#Catch any errors and reset calculator
except Exception:
print("=======================")
print("Error Please try again.")
calculator()
else:
calculator()
Operators
def add(num1,num2):
return num1 + num2
def sub(num1,num2):
return num1 - num2
def mult(num1,num2):
return num1 * num2
def div(num1,num2):
return num1 / num2
def sqrt(num1):
return (num1**(1/2.0))
Instructions
def instructions():
print("=======================")
print(format('Calculator','^25s'))
print("=======================")
print("Available operators")
print("+: Addition")
print("-: Subtraction")
print("*: Multiplication")
print("/: Division")
print("sqrt: Square Root")
print("c: Clear Calculator")
print("esc: Exit Calculator")
print("=======================")
def copy2clip(txt):
cmd='echo '+txt.strip()+'|clip'
return subprocess.check_call(cmd, shell=True)
if __name__=='__main__':
main()
python python-3.x homework calculator
python python-3.x homework calculator
edited 3 hours ago
200_success
130k17156420
130k17156420
asked 4 hours ago
user3590710
migrated from stackoverflow.com 3 hours ago
This question came from our site for professional and enthusiast programmers.
migrated from stackoverflow.com 3 hours ago
This question came from our site for professional and enthusiast programmers.
add a comment |
add a comment |
2 Answers
2
active
oldest
votes
$begingroup$
You are using function calls as if they were goto labels. That is a huge sin: it makes your program spaghetti code. If you want a loop, then write a loop. For example, main()
should look like:
def main():
while True:
#Menu
print("=======================")
print("Welcome to Calculator")
print("By: Tyler Harris")
print("=======================")
print("Menu: ")
print("[1] Calculator")
print("[2] Instructions")
print("[3] Exit")
print("=======================")
choice = input("Please select an option: ")
if choice == '1':
calculator()
elif choice == '2':
instructions()
elif choice == '3':
print("Thank you for using Calculator.")
break
else:
print("Not an option, try again:")
$endgroup$
add a comment |
$begingroup$
elif choice == '2':
instructions()
main()
Ummm, that's probably not exactly what you want.
Python lacks a goto
statement, so the usual idiom would be to wrap the whole thing in some sort of while
loop, perhaps while True
.
Consider an input sequence of "2 2 2 2 2", or "z z z z z".
You'll wind up pushing main
onto the call stack again, and again, and again....
print("Last Result: "+str(result))
Usual idiom would be print('Last Result:', result)
, but no harm done.
num1 = int(input("First Number: "))
The requirements seemed pretty clear about "...must work with decimal numbers."
You chose to invoke int()
rather than float()
.
if result != 0:
num1 = result
I can't imagine how that corresponds to The Right Thing.
If you want a sentinel, None
would be much better than 0
,
just consider a sequence like 2 + 1 = - 3 =
(which yields zero).
Perhaps there's a reason for assigning the accumulator to num1
, but I'm not seeing it.
It appears you have discarded the user input.
operator = input("Opertaor: ").lower()
Typo.
calculator()
Same criticism as above. Python lacks goto
, and you're leaking stack frames here.
if operator == "sqrt":
result = (sqrt(num1))
print("Result: "+str(result))
continue
It is apparent that I'm not understanding why you are using the result
accumulator versus the num1
user input.
On most calculators, repeated clicking of the √ key would yield repeated assignment of result = sqrt(result)
.
I'm a little concerned about num1
versus result
confusion.
if operator=="esc":
main()
Same remark about leaking stack frames.
A return
statement would be usual, here.
if operator.isdigit():
This seems a bit restrictive.
Better to unconditionally raise an "unrecognized operator" error.
num2 = int(input("Second Number: "))
Same criticism as above, the "decimal" instructions are pretty clear about calling float()
.
result = (add(num1,num2))
All four of these assignments seem pretty weird,
as for a typical calculator we'd be accumulating result = add(result, num2)
.
This is a consequence of the num1
assignment above.
Also, please discard the (
extraneous parentheses)
.
def sqrt(num1):
return (num1**(1/2.0))
This works fine, but do consider the usual idiom of simply calling math.sqrt()
.
$endgroup$
add a comment |
Your Answer
StackExchange.ifUsing("editor", function ()
return StackExchange.using("mathjaxEditing", function ()
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
);
);
, "mathjax-editing");
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216557%2fcalculator-final-project-in-python%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
2 Answers
2
active
oldest
votes
2 Answers
2
active
oldest
votes
active
oldest
votes
active
oldest
votes
$begingroup$
You are using function calls as if they were goto labels. That is a huge sin: it makes your program spaghetti code. If you want a loop, then write a loop. For example, main()
should look like:
def main():
while True:
#Menu
print("=======================")
print("Welcome to Calculator")
print("By: Tyler Harris")
print("=======================")
print("Menu: ")
print("[1] Calculator")
print("[2] Instructions")
print("[3] Exit")
print("=======================")
choice = input("Please select an option: ")
if choice == '1':
calculator()
elif choice == '2':
instructions()
elif choice == '3':
print("Thank you for using Calculator.")
break
else:
print("Not an option, try again:")
$endgroup$
add a comment |
$begingroup$
You are using function calls as if they were goto labels. That is a huge sin: it makes your program spaghetti code. If you want a loop, then write a loop. For example, main()
should look like:
def main():
while True:
#Menu
print("=======================")
print("Welcome to Calculator")
print("By: Tyler Harris")
print("=======================")
print("Menu: ")
print("[1] Calculator")
print("[2] Instructions")
print("[3] Exit")
print("=======================")
choice = input("Please select an option: ")
if choice == '1':
calculator()
elif choice == '2':
instructions()
elif choice == '3':
print("Thank you for using Calculator.")
break
else:
print("Not an option, try again:")
$endgroup$
add a comment |
$begingroup$
You are using function calls as if they were goto labels. That is a huge sin: it makes your program spaghetti code. If you want a loop, then write a loop. For example, main()
should look like:
def main():
while True:
#Menu
print("=======================")
print("Welcome to Calculator")
print("By: Tyler Harris")
print("=======================")
print("Menu: ")
print("[1] Calculator")
print("[2] Instructions")
print("[3] Exit")
print("=======================")
choice = input("Please select an option: ")
if choice == '1':
calculator()
elif choice == '2':
instructions()
elif choice == '3':
print("Thank you for using Calculator.")
break
else:
print("Not an option, try again:")
$endgroup$
You are using function calls as if they were goto labels. That is a huge sin: it makes your program spaghetti code. If you want a loop, then write a loop. For example, main()
should look like:
def main():
while True:
#Menu
print("=======================")
print("Welcome to Calculator")
print("By: Tyler Harris")
print("=======================")
print("Menu: ")
print("[1] Calculator")
print("[2] Instructions")
print("[3] Exit")
print("=======================")
choice = input("Please select an option: ")
if choice == '1':
calculator()
elif choice == '2':
instructions()
elif choice == '3':
print("Thank you for using Calculator.")
break
else:
print("Not an option, try again:")
answered 3 hours ago
200_success200_success
130k17156420
130k17156420
add a comment |
add a comment |
$begingroup$
elif choice == '2':
instructions()
main()
Ummm, that's probably not exactly what you want.
Python lacks a goto
statement, so the usual idiom would be to wrap the whole thing in some sort of while
loop, perhaps while True
.
Consider an input sequence of "2 2 2 2 2", or "z z z z z".
You'll wind up pushing main
onto the call stack again, and again, and again....
print("Last Result: "+str(result))
Usual idiom would be print('Last Result:', result)
, but no harm done.
num1 = int(input("First Number: "))
The requirements seemed pretty clear about "...must work with decimal numbers."
You chose to invoke int()
rather than float()
.
if result != 0:
num1 = result
I can't imagine how that corresponds to The Right Thing.
If you want a sentinel, None
would be much better than 0
,
just consider a sequence like 2 + 1 = - 3 =
(which yields zero).
Perhaps there's a reason for assigning the accumulator to num1
, but I'm not seeing it.
It appears you have discarded the user input.
operator = input("Opertaor: ").lower()
Typo.
calculator()
Same criticism as above. Python lacks goto
, and you're leaking stack frames here.
if operator == "sqrt":
result = (sqrt(num1))
print("Result: "+str(result))
continue
It is apparent that I'm not understanding why you are using the result
accumulator versus the num1
user input.
On most calculators, repeated clicking of the √ key would yield repeated assignment of result = sqrt(result)
.
I'm a little concerned about num1
versus result
confusion.
if operator=="esc":
main()
Same remark about leaking stack frames.
A return
statement would be usual, here.
if operator.isdigit():
This seems a bit restrictive.
Better to unconditionally raise an "unrecognized operator" error.
num2 = int(input("Second Number: "))
Same criticism as above, the "decimal" instructions are pretty clear about calling float()
.
result = (add(num1,num2))
All four of these assignments seem pretty weird,
as for a typical calculator we'd be accumulating result = add(result, num2)
.
This is a consequence of the num1
assignment above.
Also, please discard the (
extraneous parentheses)
.
def sqrt(num1):
return (num1**(1/2.0))
This works fine, but do consider the usual idiom of simply calling math.sqrt()
.
$endgroup$
add a comment |
$begingroup$
elif choice == '2':
instructions()
main()
Ummm, that's probably not exactly what you want.
Python lacks a goto
statement, so the usual idiom would be to wrap the whole thing in some sort of while
loop, perhaps while True
.
Consider an input sequence of "2 2 2 2 2", or "z z z z z".
You'll wind up pushing main
onto the call stack again, and again, and again....
print("Last Result: "+str(result))
Usual idiom would be print('Last Result:', result)
, but no harm done.
num1 = int(input("First Number: "))
The requirements seemed pretty clear about "...must work with decimal numbers."
You chose to invoke int()
rather than float()
.
if result != 0:
num1 = result
I can't imagine how that corresponds to The Right Thing.
If you want a sentinel, None
would be much better than 0
,
just consider a sequence like 2 + 1 = - 3 =
(which yields zero).
Perhaps there's a reason for assigning the accumulator to num1
, but I'm not seeing it.
It appears you have discarded the user input.
operator = input("Opertaor: ").lower()
Typo.
calculator()
Same criticism as above. Python lacks goto
, and you're leaking stack frames here.
if operator == "sqrt":
result = (sqrt(num1))
print("Result: "+str(result))
continue
It is apparent that I'm not understanding why you are using the result
accumulator versus the num1
user input.
On most calculators, repeated clicking of the √ key would yield repeated assignment of result = sqrt(result)
.
I'm a little concerned about num1
versus result
confusion.
if operator=="esc":
main()
Same remark about leaking stack frames.
A return
statement would be usual, here.
if operator.isdigit():
This seems a bit restrictive.
Better to unconditionally raise an "unrecognized operator" error.
num2 = int(input("Second Number: "))
Same criticism as above, the "decimal" instructions are pretty clear about calling float()
.
result = (add(num1,num2))
All four of these assignments seem pretty weird,
as for a typical calculator we'd be accumulating result = add(result, num2)
.
This is a consequence of the num1
assignment above.
Also, please discard the (
extraneous parentheses)
.
def sqrt(num1):
return (num1**(1/2.0))
This works fine, but do consider the usual idiom of simply calling math.sqrt()
.
$endgroup$
add a comment |
$begingroup$
elif choice == '2':
instructions()
main()
Ummm, that's probably not exactly what you want.
Python lacks a goto
statement, so the usual idiom would be to wrap the whole thing in some sort of while
loop, perhaps while True
.
Consider an input sequence of "2 2 2 2 2", or "z z z z z".
You'll wind up pushing main
onto the call stack again, and again, and again....
print("Last Result: "+str(result))
Usual idiom would be print('Last Result:', result)
, but no harm done.
num1 = int(input("First Number: "))
The requirements seemed pretty clear about "...must work with decimal numbers."
You chose to invoke int()
rather than float()
.
if result != 0:
num1 = result
I can't imagine how that corresponds to The Right Thing.
If you want a sentinel, None
would be much better than 0
,
just consider a sequence like 2 + 1 = - 3 =
(which yields zero).
Perhaps there's a reason for assigning the accumulator to num1
, but I'm not seeing it.
It appears you have discarded the user input.
operator = input("Opertaor: ").lower()
Typo.
calculator()
Same criticism as above. Python lacks goto
, and you're leaking stack frames here.
if operator == "sqrt":
result = (sqrt(num1))
print("Result: "+str(result))
continue
It is apparent that I'm not understanding why you are using the result
accumulator versus the num1
user input.
On most calculators, repeated clicking of the √ key would yield repeated assignment of result = sqrt(result)
.
I'm a little concerned about num1
versus result
confusion.
if operator=="esc":
main()
Same remark about leaking stack frames.
A return
statement would be usual, here.
if operator.isdigit():
This seems a bit restrictive.
Better to unconditionally raise an "unrecognized operator" error.
num2 = int(input("Second Number: "))
Same criticism as above, the "decimal" instructions are pretty clear about calling float()
.
result = (add(num1,num2))
All four of these assignments seem pretty weird,
as for a typical calculator we'd be accumulating result = add(result, num2)
.
This is a consequence of the num1
assignment above.
Also, please discard the (
extraneous parentheses)
.
def sqrt(num1):
return (num1**(1/2.0))
This works fine, but do consider the usual idiom of simply calling math.sqrt()
.
$endgroup$
elif choice == '2':
instructions()
main()
Ummm, that's probably not exactly what you want.
Python lacks a goto
statement, so the usual idiom would be to wrap the whole thing in some sort of while
loop, perhaps while True
.
Consider an input sequence of "2 2 2 2 2", or "z z z z z".
You'll wind up pushing main
onto the call stack again, and again, and again....
print("Last Result: "+str(result))
Usual idiom would be print('Last Result:', result)
, but no harm done.
num1 = int(input("First Number: "))
The requirements seemed pretty clear about "...must work with decimal numbers."
You chose to invoke int()
rather than float()
.
if result != 0:
num1 = result
I can't imagine how that corresponds to The Right Thing.
If you want a sentinel, None
would be much better than 0
,
just consider a sequence like 2 + 1 = - 3 =
(which yields zero).
Perhaps there's a reason for assigning the accumulator to num1
, but I'm not seeing it.
It appears you have discarded the user input.
operator = input("Opertaor: ").lower()
Typo.
calculator()
Same criticism as above. Python lacks goto
, and you're leaking stack frames here.
if operator == "sqrt":
result = (sqrt(num1))
print("Result: "+str(result))
continue
It is apparent that I'm not understanding why you are using the result
accumulator versus the num1
user input.
On most calculators, repeated clicking of the √ key would yield repeated assignment of result = sqrt(result)
.
I'm a little concerned about num1
versus result
confusion.
if operator=="esc":
main()
Same remark about leaking stack frames.
A return
statement would be usual, here.
if operator.isdigit():
This seems a bit restrictive.
Better to unconditionally raise an "unrecognized operator" error.
num2 = int(input("Second Number: "))
Same criticism as above, the "decimal" instructions are pretty clear about calling float()
.
result = (add(num1,num2))
All four of these assignments seem pretty weird,
as for a typical calculator we'd be accumulating result = add(result, num2)
.
This is a consequence of the num1
assignment above.
Also, please discard the (
extraneous parentheses)
.
def sqrt(num1):
return (num1**(1/2.0))
This works fine, but do consider the usual idiom of simply calling math.sqrt()
.
edited 1 hour ago
answered 3 hours ago
J_HJ_H
4,447130
4,447130
add a comment |
add a comment |
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216557%2fcalculator-final-project-in-python%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown